-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
template: apply splay value on change_mode script #14749
Conversation
Previously, the splay timeout was only applied if a template re-render caused a restart or a signal action. The `change_mode = "script"` was running after the `if restart || len(signals) != 0` check, so it was invoked at all times. This change refactors the logic so it's easier to notice that new `change_mode` options should start only after `splay` is applied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But what happened to the GHA runners 🤔
Oh, weird. I think it skipped a33f096 because it's just a It ran for 9d88839: https://github.com/hashicorp/nomad/actions/runs/3154058295 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Previously, the splay timeout was only applied if a template re-render caused a restart or a signal action. The
change_mode = "script"
was running after theif restart || len(signals) != 0
check, so it was invoked at all times.This change refactors the logic so it's easier to notice that new
change_mode
options should start only aftersplay
is applied.Closes #14734